Skip to content

fix: dialog title switch with select#1497

Open
zzxming wants to merge 1 commit intonpmx-dev:mainfrom
zzxming:fix-dialog-title
Open

fix: dialog title switch with select#1497
zzxming wants to merge 1 commit intonpmx-dev:mainfrom
zzxming:fix-dialog-title

Conversation

@zzxming
Copy link
Contributor

@zzxming zzxming commented Feb 14, 2026

Dialog title doesn't match facet

image

Fixed

image

@vercel
Copy link

vercel bot commented Feb 14, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 14, 2026 9:30am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 14, 2026 9:30am
npmx-lunaria Ignored Ignored Feb 14, 2026 9:30am

Request Review

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Package/WeeklyDownloadStats.vue 33.33% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 14, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The WeeklyDownloadStats.vue component now uses useI18n and a new computed modalTitle that chooses an internationalised modal title based on route.query.facet (handles likes, contributors, or default downloads). The modal title binding for PackageChartModal was replaced with :title="modalTitle". A CSS override was added to set the VueUi Sparkline text font-family to Geist Mono, monospace.

Possibly related PRs

Suggested reviewers

  • danielroe
  • 43081j
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly addresses the changeset by showing before/after screenshots demonstrating that the dialog title now matches the selected facet (e.g., 'Likes' instead of 'Downloads').
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zzxming